Default to IPv4 localhost for Node 17 compatibility #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Perry <pimterry@gmail.com>
pimterry
force-pushed
the
ipv4-default
branch
from
c8b54e2 to
01ac903
Compare
koral--
approved these changes
Dec 13, 2021
|
LGTM
I'm not a TS/coffee expert but it seems that it wasn't present as well at the time of transition to TS: 3bd94ba#diff-066f213e1d28e2d82eb24abc58dcd804134270d3dabfe5096cd1953cee17903bL59 |
drauggres
pushed a commit
to drauggres/adbkit
that referenced
this pull request
Mar 25, 2022
Default to IPv4 localhost for Node 17 compatibility refs DeviceFarmer#214 Signed-off-by: Tim Perry <pimterry@gmail.com> (cherry picked from commit 0c1c070) Signed-off-by: Sergey Volkov <s.volkov@netris.ru>
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #209. Without this adbkit is not usable with Node 17 (or any other future Node versions, presumably).
When testing locally, on my machine with Node 17.0.1 the tests today fail with:
This happens because Node 17 defaults to IPv6 and ADB's local server never listens for IPv6 connections, as far as I can tell.
This does change the default, which could affect anybody where localhost doesn't resolve to
127.0.0.1, in theory, but in practice I don't think this will cause issues - anybody who resolveslocalhostto a different IP address has a very unusual configuration and likely has other networking issues already.Interestingly, I had to add the
hostoption from scratch for this PR, even though it's already documented as existing. I guess it got lost in the TypeScript rewrite? Pretty clear from the source that it didn't work until now.