Skip to content

windows service prop script update to fix dependent services issue #53

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adbertram
Copy link
Contributor

Changed up service restart sequence and added some quality of life updates

…ling

- Introduced Write-DvlsHost function for consistent logging.
- Enhanced parameter validation and handling in the script block.
- Updated the template JSON to reflect changes in the script structure and added new properties.
- Improved error handling and service processing logic.
Copy link
Contributor

@fdubois1 fdubois1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdubois1
Copy link
Contributor

fdubois1 commented Apr 11, 2025

@adbertram There are conflicts. Could you fix them and push again ? Thanks

@adbertram
Copy link
Contributor Author

@fdubois1 The conflict is with the other pending PR. #48

I've removed that parameter completely in this new version.

@fdubois1
Copy link
Contributor

fdubois1 commented Apr 15, 2025

@fdubois1 The conflict is with the other pending PR. #48

I've removed that parameter completely in this new version.

@adbertram I don't understand what you mean. There are conflicts with your PR as well
image

I can't merge without those conflicts resolved.

@adbertram
Copy link
Contributor Author

Could you merge the other PR first?

@fdubois1
Copy link
Contributor

Could you merge the other PR first?

There is a conflict there as well. I asked Marc-Antoine to fix it first, than I will merge. But I don't expect it to fix your conflict. It depends where did you start to build your branch.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants