Skip to content

Commit

Permalink
Merge pull request #127 from GwonsooLee/hotfix_rollingupdate
Browse files Browse the repository at this point in the history
hotfix rolling update
  • Loading branch information
GwonsooLee authored Jan 21, 2021
2 parents 495beeb + 3f54068 commit 41d1c46
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
7 changes: 1 addition & 6 deletions pkg/deployer/deployer.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,7 @@ func (d *Deployer) Polling(region schemas.RegionConfig, asg *autoscaling.Group,
return false, fmt.Errorf("no autoscaling found for %s", d.AsgNames[region.Region])
}

var threshold int64
if !forceManifestCapacity && d.PrevInstanceCount[region.Region].Desired > d.Stack.Capacity.Desired && d.Mode != constants.CanaryDeployment {
threshold = d.PrevInstanceCount[region.Region].Desired
} else {
threshold = d.AppliedCapacity.Desired
}
threshold := d.AppliedCapacity.Desired

if region.HealthcheckTargetGroup == "" && region.HealthcheckLB == "" {
d.Logger.Info("health check skipped because of neither target group nor classic load balancer specified")
Expand Down
1 change: 1 addition & 0 deletions pkg/templates/templates.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Configurations of stacks
{{ decorate "underline bold" "Stack" }}: {{ $stack.Account }}
{{ decorate "underline bold" "Account" }}: {{ $stack.Account }}
{{ decorate "underline bold" "Replacement Type" }}: {{ $stack.ReplacementType }}
{{ decorate "underline bold" "Rolling Update Instance Count" }}: {{ $stack.RollingUpdateInstanceCount }}
{{ decorate "underline bold" "Environment" }}: {{ $stack.Env }}
{{ decorate "underline bold" "IAM Instance Profile" }}: {{ $stack.IamInstanceProfile }}
{{- if gt (len $stack.Tags) 0 }}
Expand Down

0 comments on commit 41d1c46

Please # to comment.