New IES plotter #104
Merged
New IES plotter #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… given the profile (currently without rotation around Z-axis which got introduced), add messy IES profile I'm working with
… render mode (currently CDC working), recreate DS3 on each CDC recreation request and let user shift by 5 degrees around Z-axis by arrow keys, have debug mode for logging data
…. Leave dummy dispatch calls for testing with RD
…in.cpp, make sure RD sees SSBOs. TODO: implement CDC sample in compute and store to image
…, add push constants with user-friendly changeable degrees. TODO: I have a bug in the implementation which makes it display my projected octahedron only currently, deal with the bug!
…o IESCompute class, use shared descriptor compute shader writes to and fragment shader samples from (CDC)
…nates & Direction sample vector TODO: move last 3 to be handled by separate full screen triangle extension pipeline/code
50.IESProfileTest/compute/cdc.comp
Outdated
Comment on lines
182
to
187
| double intensity = sampleI(degrees(sphericalCoordinates.x), degrees(sphericalCoordinates.y)); | ||
| vec4 value = vec4(intensity / pc.maxIValue, 0, 0, 0); | ||
|
|
||
| imageStore(outIESCandelaImage, pixelCoordinates, value); | ||
| imageStore(outSphericalCoordinatesImage, pixelCoordinates, vec4(sphericalCoordinates.xy, 0, 1)); | ||
| imageStore(outOUVProjectionDirectionImage, pixelCoordinates, vec4(direction.xyz, 1)); |
There was a problem hiding this comment.
something also useful that I'd do is [in another compute shader] take the IES data grid and scatter (you take raw spherical coordinate & value then figure out the destination pixel and write it there) it to an image as a "point cloud", see if there's some discrepancies
… before (silent cpp warnings), add integral tests for debugging new grid integration
…a-Examples-and-Tests into iesFeatures
…dia submodule, update main.cpp
…. R - tests if direction vector is normalized, G - tests if our spherical coordinates belong to [-PI/2,PI/2] x [-PI,PI] cartesian product
…mpute shader shifted angles it first horizontal doesn't begin with 0, fix the scene with horizontal angle it begins with and clamp to min/max hAngle range
…have debug views displaying nicely
…al range fixed into [0,PI] x [-PI,PI] CP for natural & easy mirror + mirror repeat operations. Remove previous buggy quadrant-degrees wrap implementation, work with spherical coordinates directly, update QUAD_SYMETRIC & HALF_SYMETRIC wrapping, perform tests on HALF_SYMETRIC (given OTHER_HALF_SYMETRIC profile for which horizontal angles are patched to be HALF_SYMETRIC)
… if ISOTROPIC and find big bug with it's implementation causing ISOTROPIC case to sample incorrectly, add ISOTROPIC filepath test case, update media submodule
…olation edge issues
…gs with NO_LATERAL_SYMMET, update the plotter to handle all of them, update media submodule
…or 1995 IES spec legacy case
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.