Update Project #31
Merged
Update Project #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
XedinUnknown
commented
Sep 21, 2024
•
XedinUnknown
commented
- Add support for Container Interop v2.
⚠️ Remove support for Container Interop v2.⚠️ Remove support for PHP < 7.4. The newer Container Interop versions require this, and the signatures that have to be upgraded are fundamentally incompatible due to variance.- Build on PHP up to 8.3, which means that support for the last 3 minor versions is now official.
Used to sometimes cause `docker compose build` to fail.
XedinUnknown
force-pushed
the
feature/update-project
branch
from
aaa5df2 to
6658dfe
Compare
This ensures that vimeo/psalm#5280 is implemented.
Causes a problem up until Psalm 4.30.0 whereby on CI (no `require-dev`) the non-existing directory causes an error. It seems that the original problem which was solved by having this configuration has since been fixed.
Importantly, converts line endings
XedinUnknown
force-pushed
the
feature/update-project
branch
from
e80eacb to
91cc801
Compare
Making it explicit that support for Container Interop v1 is dropped.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.