Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Recursive dependency detection #13

Merged
merged 7 commits into from
Sep 21, 2024
Merged

Recursive dependency detection #13

merged 7 commits into from
Sep 21, 2024

Conversation

mecha
Copy link
Member

@mecha mecha commented Sep 15, 2020

Solution for #10

@mecha mecha added the enhancement New feature or request label Sep 15, 2020
@mecha mecha requested a review from XedinUnknown September 15, 2020 16:33
@mecha mecha self-assigned this Sep 15, 2020
@mecha mecha force-pushed the recursive-detection branch from 63c127b to c2aeb03 Compare September 15, 2020 16:34
@mecha mecha linked an issue Sep 15, 2020 that may be closed by this pull request
Copy link
Member

@XedinUnknown XedinUnknown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Just one question.

src/DelegatingContainer.php Outdated Show resolved Hide resolved
# Conflicts:
#	src/DelegatingContainer.php
@XedinUnknown XedinUnknown changed the base branch from 0.1.x to 0.2.x September 21, 2024 17:11
This prevents other unrelated delegating containers from manipulating the stack.
Copy link
Member

@XedinUnknown XedinUnknown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@XedinUnknown XedinUnknown merged commit 15c2e80 into 0.2.x Sep 21, 2024
5 checks passed
@XedinUnknown XedinUnknown deleted the recursive-detection branch September 21, 2024 18:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect Recursive References
2 participants