-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Service Tagging Capability #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mecha
reviewed
Nov 7, 2023
Co-authored-by: Miguel Muscat <miguelmuscat93@gmail.com>
XedinUnknown
commented
Nov 23, 2023
Looking good! @Biont has also had a look at this, and I have received positive feedback. Thanks, all! |
The default calculation should only have effect when `$length` has the default value of `null`, not when it's just falsy.
This suppresses a bunch of errors en-masse. They are very difficult to satisfy. See also vimeo/psalm#10922
Added description of Service Tagging feature.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can tag your services, like so:
For every unique tag, an extension is added that resolves tagged services and adds them to the list. The list is ensured by also creating an empty list factory with the same name.