Skip to content
This repository has been archived by the owner on Jul 10, 2019. It is now read-only.

Make Annotation's serializable and initial implementation of adding annotations to the Exporter output #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lewismc
Copy link
Contributor

@lewismc lewismc commented Jul 29, 2015

Hi @jnioche ,
Please see the patch below which does the following

  • makes Annotation’s serializable, meaning we can export them alongside document text as either binary or textual content.
  • implements the command line boolean flag for facilitating the above
  • implements the core logic for exporting Annotations as string values, comma separated
  • concatenates both textual content and annotations, then deep clones the object and returns it for exporting.

An issue is that the concatenation is not a join.
What do you think about the patch. Is it worthy of inclusion into Behemoth?

@jnioche
Copy link
Member

jnioche commented Jul 29, 2015

Hi @lewismc - will have a closer look when coming back from holiday. Thanks

@lewismc
Copy link
Contributor Author

lewismc commented Jul 29, 2015

Enjoy holidays @jnioche safe travels

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants