qt6 compatibility and fixes removing sources bug #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DillonWall
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Tested and working as intended. I'm baffled that the entire bug was those 2 lines haha, my guess is that I added those lines as a workaround to a previous bug that has since been fixed. Nice fix and thank you for helping with the update to the newer qt versions as well.
I will go ahead and deploy these changes to the public and release as a new version.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now compatible with qt5/6. Fixed the menu source bug by deleting two lines.