Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Chore: hoist example projects for discoverability #2959

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

jkelleyrtp
Copy link
Member

@jkelleyrtp jkelleyrtp commented Sep 13, 2024

Hoist all of our example projects into a top-level "example-projects" folder, similar to NextJS and Leptos.

This should make discoverability easier.

Also removes the OIDC example since it wasn't working and wasn't properly updated for 0.5.

Cut out of #2779 to make that PR smaller

Closes DioxusLabs/example-projects#45

@jkelleyrtp jkelleyrtp requested a review from ealmloff September 13, 2024 20:30
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these examples being at the top level, but the /examples vs /example-projects distinction doesn't seem that useful. Many of these examples are simple unstyled examples that happen to use a full project to make the cargo.toml easier to copy. It might be better to just keep the example-projects we moved over from the original repo in the folder and fullstack-hackernews and move the rest of the full crate examples into the examples folder

@ealmloff ealmloff added example Update examples organization Layout of the repository labels Sep 13, 2024
@ealmloff ealmloff marked this pull request as draft September 13, 2024 21:38
@ealmloff ealmloff marked this pull request as ready for review September 16, 2024 13:08
@ealmloff ealmloff merged commit 983fcfc into main Sep 16, 2024
30 checks passed
@ealmloff ealmloff deleted the jk/hoist-example-projects branch September 16, 2024 14:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
example Update examples organization Layout of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite examples with Dioxus v0.5
2 participants