Skip to content

Changes to support axum 0.8 #3820

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Apr 15, 2025

Conversation

CristianCapsuna
Copy link
Contributor

@CristianCapsuna CristianCapsuna commented Mar 3, 2025

Hi guys. Very excited to make my first, small, contribution.

Before this PR can be closed, the server_fn and server_fn_macro dependencies need to be pointed to their released crates once those are available.

I was not able to do the make tests but I don't think it's because of this. See below. Any guidance on how I could make this work?
Screenshot from 2025-03-03 16-07-33

I plugged this is my wannabe website project and it worked fine.

Closes #3479

@CristianCapsuna CristianCapsuna requested a review from a team as a code owner March 3, 2025 16:08
@CristianCapsuna
Copy link
Contributor Author

CristianCapsuna commented Mar 4, 2025

The change to the cli/src/serve/server.rs was done after reading this.

Are there any other tests I should do for the fullstack-auth example? Personally I am not fond of it. I have chosen to use Max Countryman's tower-sessions and axum-login as I found them easier to understand. The community seems to agree with that sentiment looking at the stars for the repos. At some point I will make an example for it.

Lastly, I noted that the command used in the CI/CD pipeline for checking is cargo check --workspace --all-features --all-targets. The latest version of the Contributing page suggests using cargo check --workspace --examples --tests. The former does not show any issues where latter does. Is there a way to submit an update to the docs page?

@CristianCapsuna
Copy link
Contributor Author

@ealmloff would you have any guidance on what the problem is with the playwright test?

@ealmloff
Copy link
Member

ealmloff commented Mar 7, 2025

@ealmloff would you have any guidance on what the problem is with the playwright test?

My guess is some of the CLI changes are causing it to not proxy the fullstack server. Try going into one of the playwright tests and running the server command manually then opening the site

@ealmloff ealmloff added breaking This is a breaking change dependencies Pull requests that update a dependency file fullstack related to the fullstack crate labels Mar 12, 2025
@ealmloff
Copy link
Member

ealmloff commented Mar 21, 2025

I pulled in the latest git version of server_fn which includes leptos-rs/leptos#3725. That makes our server function integration much simpler. The server fn crate has a 0.8 beta out, but it doesn't include that change yet. It sounds like a full 0.8 release is coming soon

The windows CI issue is unrelated to this PR

Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to follow this up with the other PR that moves everything over to axum 0.8, but this is good for now!

I moved us to the 0.8 pre-release of server_fn though we might just end up forking it.

@jkelleyrtp jkelleyrtp merged commit 1379de7 into DioxusLabs:main Apr 15, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
breaking This is a breaking change dependencies Pull requests that update a dependency file fullstack related to the fullstack crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to axum 0.8.x breaks DioxusRouterExt
3 participants