Fix ObservableCollection Reset notification handling #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for #184 where the previous handler assumed the collection was cleared when the
NotifyCollectionChangedAction.Reset
action was received. The new handler iterates through the collection to find which items were removed and then only removes those items.I added a test for the
Reset
handling in the AutomationTestAvalonDockTest
project. It creates severalAnchorables
andDocuments
and uses aCustomObservableCollection
that raises theReset
notification. I also modified that project (AvalonDockTest
) to the newcsproj
format because the reference toAvalonDock
since it had the new file format. There was an issue with the Apartment STA, so I referenced a nuget project to help with that.Finally, I added a new test project
CaliburnDockTestApp
that is a simplified version of my original test project AvalonDockTestIssue.