Handle CanClose and CanHide in XAML #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and modify XAML in themes to react on CanClose = false and CanHide = true and use HideCommand instead of Close Command
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's another set of changes improving behavior when anchorable is docked in document area.
In original code there was a bodge using SetCanCloseInternal/ResetCanCloseInternal methods to store and restore CanClose state during window drag-drop operation. With my changes that bodge is removed and instead style for LayoutDocumentTabItem is improved in per theme XAMLs to react properly on CanClose = false and CanHide = true and use HideCommand instead of Close Command.