Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Issue #226: Restore floating windows to maximized state #416

Merged
merged 1 commit into from
Jan 29, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,21 @@ private set
protected override void OnStateChanged(EventArgs e)
{
if (!_isInternalChange)
UpdateMaximizedState(WindowState == WindowState.Maximized);
{
if (WindowState == WindowState.Maximized)
{
// Forward external changes to WindowState from any state to a new Maximized state
// to the LayoutFloatingWindowControl internal representation.
UpdateMaximizedState(true);
}
else if (IsMaximized && OwnedByDockingManagerWindow)
{
// Override any external changes to WindowState when owned and in Maximized state.
// This override fixes the issue of an owned LayoutFloatingWindowControl loosing
// its Maximized state when the owner window is restored from a Minimized state.
WindowState = WindowState.Maximized;
}
}

base.OnStateChanged(e);
}
Expand Down