Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Complete Injection and commands.register_injection typing #669

Closed
onerandomusername opened this issue Jul 28, 2022 · 0 comments · Fixed by #675
Closed

Complete Injection and commands.register_injection typing #669

onerandomusername opened this issue Jul 28, 2022 · 0 comments · Fixed by #675
Labels
feature request Request for a new feature
Milestone
disnake v2.6

Comments

@onerandomusername
Copy link
Member

onerandomusername commented Jul 28, 2022 •
edited
Loading

Summary

Incomplete typing on commands.register_injection and Injection

What is the feature request for?

disnake.ext.commands

The Problem

using commands.register_injection doesn't return anything which means this injection cannot be used like other decorators cog which is annoying and disappointing.

The Ideal Solution

The commands.register_injection method should return an Injection instance and additionally be fully typed so it can decorate a method without returning nothing.

The Current Solution

No response

Additional Context

No response
@onerandomusername onerandomusername added the feature request Request for a new feature label Jul 28, 2022
@onerandomusername onerandomusername mentioned this issue Jul 28, 2022
Closed
@onerandomusername onerandomusername moved this to Todo in disnake Jul 28, 2022
@onerandomusername onerandomusername added this to the disnake v2.6 milestone Aug 28, 2022
@onerandomusername onerandomusername changed the title Complete Injection and commands.inject typing Complete Injection and commands.register_injection typing Sep 11, 2022
@onerandomusername onerandomusername mentioned this issue Sep 11, 2022
Merged
8 tasks
@onerandomusername onerandomusername linked a pull request Sep 11, 2022 that will close this issue
feat(commands)!: Add support for injected parameters autocompletions #675
Merged
8 tasks
@onerandomusername onerandomusername removed a link to a pull request Sep 11, 2022
feat(commands)!: Add support for injected parameters autocompletions #675
Merged
8 tasks
@onerandomusername onerandomusername linked a pull request Sep 16, 2022 that will close this issue
feat(commands)!: Add support for injected parameters autocompletions #675
Merged
8 tasks
Repository owner moved this from Todo to Done in disnake Sep 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
feature request Request for a new feature
Projects
disnake
Status: Done
Milestone
disnake v2.6
Development

Successfully merging a pull request may close this issue.

feat(commands)!: Add support for injected parameters autocompletions
1 participant
@onerandomusername