Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(commands)!: Add support for injected parameters autocompletions #675

Merged
merged 116 commits into from
Sep 26, 2022
Merged

feat(commands)!: Add support for injected parameters autocompletions #675

merged 116 commits into from
Sep 26, 2022

Conversation

elenakrittik
Copy link
Contributor

@elenakrittik elenakrittik commented Jul 28, 2022 •
edited
Loading

Summary

Resolves #670

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature s: needs review Issue/PR is awaiting reviews labels Jul 29, 2022
@shiftinv shiftinv added this to the disnake v2.6 milestone Jul 29, 2022
@elenakrittik elenakrittik changed the title feat: Add support for injected parameters autocompletions feat(commands): Add support for injected parameters autocompletions Jul 30, 2022
@shiftinv shiftinv self-requested a review August 17, 2022 23:46
shiftinv
shiftinv requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!
Got a few comments, a lot of which are documentation nitpicks :)

disnake/ext/commands/params.py Outdated Show resolved Hide resolved
disnake/ext/commands/params.py Outdated Show resolved Hide resolved
disnake/ext/commands/params.py Outdated Show resolved Hide resolved
disnake/ext/commands/params.py Outdated Show resolved Hide resolved
disnake/ext/commands/params.py Outdated Show resolved Hide resolved
disnake/ext/commands/params.py Outdated Show resolved Hide resolved
disnake/ext/commands/params.py Outdated Show resolved Hide resolved
disnake/ext/commands/params.py Outdated Show resolved Hide resolved
docs/ext/commands/api.rst Outdated Show resolved Hide resolved
test_bot/main.py Outdated Show resolved Hide resolved
elenakrittik and others added 9 commits August 20, 2022 08:58
@elenakrittik
Merge branch 'master' into injected-autocomp
edcbd39
@elenakrittik @shiftinv
Update disnake/ext/commands/params.py
ce2d21f 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@elenakrittik @shiftinv
Update disnake/ext/commands/params.py
1bde44b 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@elenakrittik @shiftinv
Update disnake/ext/commands/params.py
aea017a 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@elenakrittik @shiftinv
Update changelog/670.feature.rst
e29033d 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@elenakrittik @shiftinv
Update disnake/ext/commands/params.py
81ce952 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@elenakrittik @shiftinv
Update disnake/ext/commands/params.py
1a9eb56 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@elenakrittik @shiftinv
Update disnake/ext/commands/params.py
96ac58d 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@elenakrittik @shiftinv
Update disnake/ext/commands/params.py
edf0b00 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@shiftinv shiftinv mentioned this pull request Sep 19, 2022
Merged
8 tasks
@elenakrittik
Copy link
Contributor Author

Seems like EQ fixed it :O

@onerandomusername onerandomusername added the s: blocked Issue/PR is blocked by other issues label Sep 21, 2022
@shiftinv shiftinv removed the s: blocked Issue/PR is blocked by other issues label Sep 25, 2022
@onerandomusername
Copy link
Member

#675 (comment)

@shiftinv this should be fixed as of 5f9e404 and 260ee48

@onerandomusername
Copy link
Member

@shiftinv would you please review too?

shiftinv
shiftinv reviewed Sep 25, 2022
View reviewed changes
changelog/669.feature.rst Outdated Show resolved Hide resolved
@shiftinv shiftinv requested a review from EQUENOS September 25, 2022 20:18
@elenakrittik elenakrittik changed the title feat(commands): Add support for injected parameters autocompletions feat(commands)!: Add support for injected parameters autocompletions Sep 26, 2022
@onerandomusername onerandomusername merged commit fa04e69 into DisnakeDev:master Sep 26, 2022
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Sep 26, 2022
@elenakrittik elenakrittik deleted the injected-autocomp branch September 26, 2022 14:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@onerandomusername onerandomusername onerandomusername approved these changes

@EQUENOS EQUENOS EQUENOS approved these changes

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.6
Development

Successfully merging this pull request may close these issues.

Support autocomplete on Injections Complete Injection and commands.register_injection typing
4 participants
@elenakrittik @onerandomusername @shiftinv @EQUENOS