Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve blank lines around FOOTNOTES headings #691

Closed
windymilla opened this issue Jan 23, 2025 · 0 comments · Fixed by #697
Closed

Improve blank lines around FOOTNOTES headings #691

windymilla opened this issue Jan 23, 2025 · 0 comments · Fixed by #697
Assignees
@windymilla
Labels
bug Something isn't working

Comments

@windymilla
Copy link
Collaborator

As described in #688, you can end up with 4 blank lines before a FOOTNOTES heading and only 1 blank line afterwards.
Suggestion:
When moving footnotes to LZ, if the FOOTNOTES heading has 4 blank lines before, make sure that there are 2 blank lines before the first footnote
@windymilla windymilla added the bug Something isn't working label Jan 23, 2025
@windymilla windymilla self-assigned this Jan 23, 2025
@windymilla windymilla mentioned this issue Jan 23, 2025
Merged
windymilla added a commit to windymilla/guiguts-py that referenced this issue Jan 25, 2025
@windymilla
Ensure FOOTNOTES heading has correct blank lines
1934799 
After moving footnotes to LZ, code now checks if the
FOOTNOTES heading has 4 blank lines before it.
If it does, then make sure it has at least 2 blank lines
after it.

Testing note: if you manually edit LZ blank lines in order
to test this, you should re-run the footnotes tool to
ensure it knows all the locations correctly.

Fixes DistributedProofreaders#691
@windymilla windymilla mentioned this issue Jan 25, 2025
Merged
windymilla added a commit to windymilla/guiguts-py that referenced this issue Jan 29, 2025
@windymilla
Ensure FOOTNOTES heading has correct blank lines
53424bd 
After moving footnotes to LZ, code now checks if the
FOOTNOTES heading has 4 blank lines before it.
If it does, then make sure it has at least 2 blank lines
after it.

Testing note: if you manually edit LZ blank lines in order
to test this, you should re-run the footnotes tool to
ensure it knows all the locations correctly.

Fixes DistributedProofreaders#691
windymilla added a commit that referenced this issue Jan 29, 2025
@windymilla
Ensure FOOTNOTES heading has correct blank lines (#697)
668e212 
After moving footnotes to LZ, code now checks if the
FOOTNOTES heading has 4 blank lines before it.
If it does, then make sure it has at least 2 blank lines
after it.

Testing note: if you manually edit LZ blank lines in order
to test this, you should re-run the footnotes tool to
ensure it knows all the locations correctly.

Fixes #691
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@windymilla windymilla

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure FOOTNOTES heading has correct blank lines windymilla/guiguts-py
1 participant
@windymilla