Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

libraries update - php8.3 added, actions/checkout updated, codeception/lib-innerbrowser updated #28

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

xklid101
Copy link
Contributor

lib update actions/checkout to use v4
dropped php8.0 support
added php8.3 support
lib update: codeception/lib-innerbrowser version ^4.0

All tests are passing ok without another source code changes.
Php8.0 didn't work with some lib update, but it isn't supported by php anyway.

(It could be just fine for me to make the new release version with these changes.)

    lib update actions/checkout to use v4
    dropped php8.0 support
    added php8.3 support
    lib update: codeception/lib-innerbrowser version ^4.0
Copy link
Collaborator

@szhajdu szhajdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Could you please keep PHP 8.0 support and update the changelog? I don't see any reason to drop the support for now. What was the issue you encountered?

@szhajdu szhajdu self-assigned this Mar 14, 2024
@xklid101 xklid101 changed the title libraries update - php8.0 dropped, php8.3 added, actions/checkout updated, codeception/lib-innerbrowser updated libraries update - php8.3 added, actions/checkout updated, codeception/lib-innerbrowser updated Mar 14, 2024
@szhajdu szhajdu merged commit 4921cda into DoclerLabs:master Mar 15, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants