Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix error in Safari with "use strict" #59

Closed
wants to merge 1 commit into from
Closed

Fix error in Safari with "use strict" #59

wants to merge 1 commit into from

Conversation

leedorian
Copy link

When using in Safari, got error:

SyntaxError: Strict mode does not allow function declarations in a lexically nested statement.

This because the "callPrint" function is declared in try catch statement.

@CitizenOfRome
Copy link

Thank you for taking the time and effort for this PR.
Do you think we could have it work while keeping the "use strict"; declaration?
What version of Safari are you on?

@leedorian
Copy link
Author

I did some changes on "callPrint" function, make it work in Safari when keeping the "use strict", and committed the merge request, please check.

@CitizenOfRome
Copy link

That sounds good.
The commit seems to be missing though, could you please check?

Thanks!

@CitizenOfRome
Copy link

Went with @3kthor3adward's #64 as it's simpler.
Thanks anyways @leedorian

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants