-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add RBAC decorator and plugin #321
Conversation
This is super useful! Needs docs indeed. In my opinion, we could get rid of the |
4fcc21c
to
46131a7
Compare
@davidolrik I'd still love to include this, but it still needs documentation. Are you planning to provide that? |
Definitely! |
04b2253
to
4dd1c89
Compare
@dandydev: I've added docs - let me know if it is enough, and if it is placed correctly. |
I've also rebased it with |
588c61f
to
f1a9a5a
Compare
f1a9a5a
to
5e82ef3
Compare
Rebased with master. |
Add comment about copying func docs and meta data
5e82ef3
to
6ee13b5
Compare
Rebased with master. |
@dandydev Are there anything more needed for this to be merged? |
Sorry for the super late response. I was switching jobs and have a new puppy that takes a lot of my spare time. This looks great and there's only one small change in the docs that is required before I can merge. |
No worries =) - I have a Golden my self, which kind of puppy? |
What a lovely doggo! This PR has turned out to be the most wholesome PR in my open source career so far ;) |
Merged! |
Lets make more PR's like this then 😁 |
Role based authentication for use in plugins.
Included in this pull request is two decorators:
rbac_require_any_role
andrbac_require_all_role
, and a "admin" plugin for assigning roles dynamically, and for being notified of people trying to use commands they aren't allowed to.Still needs docs and better error handling for edge cases.