Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add support for set topic on channels #839

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

jogendra
Copy link

@jogendra jogendra commented Aug 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #839 (d28116e) into main (99f6107) will decrease coverage by 0.06%.
The diff coverage is 40.00%.

❗ Current head d28116e differs from pull request most recent head e534644. Consider uploading reports for the commit e534644 to get more accurate results

@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
- Coverage   74.10%   74.05%   -0.06%     
==========================================
  Files          26       26              
  Lines        1263     1272       +9     
==========================================
+ Hits          936      942       +6     
- Misses        327      330       +3     
Files Changed Coverage Δ
machine/clients/slack.py 64.11% <33.33%> (-0.56%) ⬇️
machine/plugins/base.py 75.00% <50.00%> (-0.81%) ⬇️

... and 2 files with indirect coverage changes

@DonDebonair
Copy link
Owner

Awesome! Can you rebase your branch on main? I did a lot of dependency updates today.
Also, if you want, you can add yourself to the AUTHORS file

@jogendra jogendra force-pushed the support_set_topic branch from d28116e to e534644 Compare August 6, 2023 11:59
@DonDebonair DonDebonair merged commit 6ab4cb9 into DonDebonair:main Aug 9, 2023
@jogendra jogendra deleted the support_set_topic branch August 9, 2023 14:56
@DonDebonair
Copy link
Owner

Released in v0.34.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants