Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix projectMembers.delete not including type #16

Closed
wants to merge 2 commits into from

Conversation

mikewuu
Copy link

@mikewuu mikewuu commented Jan 15, 2024

Fixes ('type' must be one of [workplace_user,group,invite,service_account].) error on projectMembers.delete

Issue

Was previously looking for {type_} with underscore, where the URL endpoint has {type}.

Notable things

  • Also updated methods projectMembers.get & projectMembers.update

@seveibar
Copy link

@Piccirello this is blocking seam.co from doing stuff, would appreciate a look!

@Piccirello
Copy link
Contributor

FYI @nmanoogian. The Readme API docs look right but guessing it's something on that side.

@nmanoogian
Copy link
Member

Thanks for the ping, @Piccirello! And thanks @seveibar for reporting -- we'll take a look!

@apazzolini
Copy link
Collaborator

apazzolini commented Jan 26, 2024

Hi @mikewuu (cc @seveibar) - I appreciate the effort you put into this PR, but unfortunately we can't accept it as the SDK is autogenerated from an OpenAPI spec and the changes would be clobbered the next time it runs.

We've created an internal issue to address this but I don't have an ETA for you at the moment.

@mikewuu
Copy link
Author

mikewuu commented Jan 30, 2024

@apazzolini no worries. I've created a public issue, #17, to track this as we're blocked here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants