Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix install on Windows #51

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix install on Windows #51

merged 1 commit into from
Jan 7, 2025

Conversation

gregkalata
Copy link
Contributor

Replaced a native path separator with Unix one to prevent "Could not determine pumla installation path" error

@gregkalata
Fix install on Windows
c95bfc6 
- replaced native path separator with Unix one to prevent "Could not determine pumla installation path" error
DrMarkusVoss
DrMarkusVoss approved these changes Jan 7, 2025
View reviewed changes
Copy link
Owner

@DrMarkusVoss DrMarkusVoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will likely not be the only place where the separator needs to be fixed to gain OS independence, but its a start. as I do not own a windows machine, I cannot test success for windows, but it does not break the solution for *nix.

@DrMarkusVoss DrMarkusVoss merged commit 1a8cfa1 into DrMarkusVoss:main Jan 7, 2025
@gregkalata gregkalata deleted the PR-fix-install-on-Windows branch January 8, 2025 08:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@DrMarkusVoss DrMarkusVoss DrMarkusVoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregkalata @DrMarkusVoss