Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix style ci failed #20

Merged
merged 1 commit into from
Oct 31, 2019
Merged

fix style ci failed #20

merged 1 commit into from
Oct 31, 2019

Conversation

ntuple
Copy link
Contributor

@ntuple ntuple commented Oct 9, 2019

No description provided.

@DrudgeRajen
Copy link
Owner

DrudgeRajen commented Oct 10, 2019 •
edited
Loading

Hi @ntuple ,

VDO is using voyager 1.1 which supports laravel 5.4 which is valid for php 5.6 and array de-structuring is only available since php7.1. So, in order to fix this we need to update the voyager version as well.

@DrudgeRajen
Copy link
Owner

DrudgeRajen commented Oct 31, 2019 •
edited
Loading

Updated the version of voyager #23 .

@DrudgeRajen DrudgeRajen merged commit b7a7331 into DrudgeRajen:master Oct 31, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntuple @DrudgeRajen