remove redundant check for isset() which is unnecessary in case of unset()
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.MD
Outdated
| @@ -1,7 +1,7 @@ | |||
| [](https://github.styleci.io/repos/159037396) | |||
| ### Introduction | |||
| <a href = "https://github.com/the-control-group/voyager">Voyager </a> is an awesome admin tool for laravel. | |||
| It's easy to create admin tool for CMS using it awesome features ```BREAD```. | |||
| It's easy to create admin tool for CMS using its awesome features ```BREAD```. | |||
There was a problem hiding this comment.
Suggested change
| It's easy to create admin tool for CMS using its awesome features ```BREAD```. | |
| It's easy to create admin tool for CMS using its awesome features `BREAD`. |
README.MD
Outdated
|
|
||
| After Publishing the ``VoyagerDeploymentOrchestratorSeeder`` class file | ||
| autoload the composer so that laravel knows about the seeder. | ||
| After Publishing the ``VoyagerDeploymentOrchestratorSeeder`` class file, |
There was a problem hiding this comment.
Suggested change
| After Publishing the ``VoyagerDeploymentOrchestratorSeeder`` class file, | |
| After Publishing the `VoyagerDeploymentOrchestratorSeeder` class file, |
| @@ -117,15 +117,13 @@ private function populateDataTypeSeederContent(string $stub, DataType $dataType) | |||
| $stub = $this->populatePermissionStatements($stub, $dataType); | |||
| $stub = $this->populateMenuStatements($stub, $dataType); | |||
|
|
|||
| list($dataType, $stub) = $this->populateTranslationStatements($stub, $dataType); | |||
| [$dataType, $stub] = $this->populateTranslationStatements($stub, $dataType); | |||
There was a problem hiding this comment.
Will possibly not work on Laravel 5.4 and 5.5 as array destructuring is only available since PHP7.1
There was a problem hiding this comment.
This change was reported by StyleCI so I made this change. I think we will need to make change on styleCI configuration on dashboard.
There was a problem hiding this comment.
@samundra better to revert this change in this PR and fix CI issue in another one
There was a problem hiding this comment.
Sounds good. I will revert this change.
|
@samundra would you please resolve the conflicts? |
Fixed. Thank you. |
|
@samundra Thank you |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has following changes:
unset()