Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Correctly interpolate diurnal soil temperature range #310

Open
dschlaep opened this issue May 27, 2022 · 0 comments
Open

Correctly interpolate diurnal soil temperature range #310

dschlaep opened this issue May 27, 2022 · 0 comments

Comments

@dschlaep
Copy link
Member

  • the translation of values of the regularly spaced soil temperature profile to the soil layer profile would be producing negative values for the diurnal soil temperature range, lyrTemp_to_lyrSoil_temperature()
  • this was because the interpolation uses a simple 2-point linear interpolation whereas the the diurnal soil temperature range is dampened exponentially with soil depth

-> currently a quick patch avoids negative values; however, a better solution would be to use a more careful interpolation (probably also with a more direct approach than the weighing-scheme utilized for mean soil temperature by lyrTemp_to_lyrSoil_temperature())

dschlaep added a commit that referenced this issue May 27, 2022
- the translation of values of the regularly spaced soil temperature profile to the soil layer profile was previously producing negative values for the diurnal soil temperature range
- this was because the interpolation uses a simple 2-point linear interpolation whereas the the diurnal soil temperature range is dampened exponentially with soil depth

-> this commit provides a quick patch (i.e., forces the interpolated range to be >= 0); however, a better solution would be to use a more careful interpolation (see new issue #310)
@dschlaep dschlaep added this to the main development milestone Oct 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant