Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Reconsider test examples 1-5 #203

Open
dschlaep opened this issue Jul 25, 2022 · 0 comments
Open

Reconsider test examples 1-5 #203

dschlaep opened this issue Jul 25, 2022 · 0 comments
Milestone
Code testing

Comments

@dschlaep
Copy link
Member

Currently,

  • example1: default setup
  • example2: weather generator
  • example3: use soil temperature
  • example4: use CO2-effects
  • example5: tilted surface

However, example3 and example4 are identical to example1.

Consider,

  1. removing example3 and example4 or
  2. turning off those features (that are now turned on by default as in example 1)
@dschlaep dschlaep added this to the Code testing milestone Jul 25, 2022
dschlaep added a commit that referenced this issue Jul 26, 2022
@dschlaep
New tests to check example data
db1578f 
- check expectation that example data are indeed behaving as they were defined to do (see script data-raw/prepare_testInput_objects.R)

-> checks for example2 are currently failing because no weather is missing
--> this is because recent commit 2c64be5 applies the weather generator during obtaining weather data

- see issue #203 "Reconsider test examples 1-5" (example3 and example4 are identical to example1)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Code testing
Development

No branches or pull requests
1 participant
@dschlaep