Use CustomBaseModel
on all endpoint models and make fields Optional
#365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you take a look at the merge requests in this project, most of them were created by breaking model assumptions and setting individual fields to
Optional
.This merge request introduces a
CustomBaseModel
that automatically generatesNone
values for values that do not match the data types of the model assumptions. In addition, all data types of the fields in the models were set toOptional
.This does not immediately make things better, but at least an error is no longer immediately thrown if the model assumptions break. This means that the models and the
mytoyota
lib remain functional within the scope of the information available and can continue to be used by end users if Toyota changes something in the API again.