Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Compilation failure caused by unused import in dim-core #610

Open
pluiedev opened this issue May 8, 2024 · 0 comments · May be fixed by #611
Open

Compilation failure caused by unused import in dim-core #610

pluiedev opened this issue May 8, 2024 · 0 comments · May be fixed by #611
Labels
S-needs-triage Status: Needs triage T-bug Something isn't working the way it is supposed to

Comments

@pluiedev
Copy link

pluiedev commented May 8, 2024 •
edited
Loading

Describe the bug
There's an unused import of all things in dim-core that's preventing dim from building due to a #[deny(unused_imports)] lint:

dim/dim-core/src/scanner/movie.rs

Line 3 in 3ccb4ab

use crate::inspect::ResultExt;
,

dim/dim-core/src/scanner/tv_show.rs

Line 10 in 3ccb4ab

use crate::inspect::ResultExt;

Logs: https://hydra.nixos.org/build/258208814/nixlog/1

To Reproduce

  1. cargo check

Expected behavior
It should compile.

Device and browser including versions:
N/A
@pluiedev pluiedev added S-needs-triage Status: Needs triage T-bug Something isn't working the way it is supposed to labels May 8, 2024
pluiedev added a commit to pluiedev/dim that referenced this issue May 8, 2024
@pluiedev
remove unused imports (fixes Dusk-Labs#610)
f62de1d
This was referenced May 8, 2024
Open
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
S-needs-triage Status: Needs triage T-bug Something isn't working the way it is supposed to
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build failure by removing unused imports pluiedev/dim
1 participant
@pluiedev