Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dim: fix build failure #310085

Merged
merged 1 commit into from
May 8, 2024
Merged

dim: fix build failure #310085

merged 1 commit into from
May 8, 2024

Conversation

pluiedev
Copy link
Member

@pluiedev pluiedev commented May 8, 2024

Description of changes

Who would've thought it's caused by unused imports of all things...? See Dusk-Labs/dim#610, Dusk-Labs/dim#611.

Part of the ongoing ZHF campaign for 24.05.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Who would've thought it's caused by unused imports of all things...?
@ofborg ofborg bot requested a review from Misterio77 May 8, 2024 12:27
@wegank wegank merged commit 57043c2 into NixOS:master May 8, 2024
27 of 28 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants