Skip to content

Commit

Permalink
fix: add cross-env so env. variables can be used in different OSs (#488)
Browse files Browse the repository at this point in the history
* fix: add cross-env so env. variables can be used in different OSs

* fix: add signing to commitizen

* fix: change commitizen flag

* fix: removing universal from workflows again?

* fix: change commitizen sign command

* fix: use correct sign command for comittizen
  • Loading branch information
javierguzman authored Aug 11, 2023
1 parent 1bf911f commit 400cd6c
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ jobs:
with:
name: artifacts
path: |
out/make/**/*universal.dmg
out/make/**/*.dmg
out/make/**/*.AppImage
windows_signing/**/*.exe
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ jobs:
with:
name: artifacts
path: |
out/make/**/*universal.dmg
out/make/**/*.dmg
out/make/**/*.AppImage
windows_signing/**/*.exe
Expand Down
2 changes: 1 addition & 1 deletion .husky/prepare-commit-msg
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

test -t 1 && exec < /dev/tty && npx cz --hook || true
test -t 1 && exec < /dev/tty && npx cz -s --hook || true
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"main": ".webpack/main",
"scripts": {
"clean": "rm -rf dist && rm -rf out && rm -rf node_modules",
"start": "NODE_ENV=development electron-forge start",
"make-dev": "NODE_ENV=development electron-forge make --platform=darwin",
"start": "cross-env NODE_ENV=development electron-forge start",
"make-dev": "cross-env NODE_ENV=development electron-forge make --platform=darwin",
"package": "electron-forge package",
"make": "electron-forge make",
"make-win": "electron-forge make --platform=win32",
Expand All @@ -22,7 +22,7 @@
"prettier": "prettier --write \"./**/*.{js,json,css,scss,md}\"",
"test": "vitest run src/renderer/tests src/main/tests",
"e2e": "yarn playwright test",
"commit": "cz",
"commit": "cz -s",
"prepare": "husky install"
},
"keywords": [
Expand Down Expand Up @@ -73,6 +73,7 @@
"@vercel/webpack-asset-relocator-loader": "1.7.3",
"babel-loader": "^9.1.2",
"copy-webpack-plugin": "^11.0.0",
"cross-env": "^7.0.3",
"css-loader": "^6.0.0",
"cz-conventional-changelog": "^3.3.0",
"electron": "^25.2.0",
Expand Down
7 changes: 7 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4465,6 +4465,13 @@ create-require@^1.1.0:
resolved "https://registry.yarnpkg.com/create-require/-/create-require-1.1.1.tgz#c1d7e8f1e5f6cfc9ff65f9cd352d37348756c333"
integrity sha512-dcKFX3jn0MpIaXjisoRvexIJVEKzaq7z2rZKxf+MSr9TkdmHmsU4m2lcLojrj/FHl8mk5VxMmYA+ftRkP/3oKQ==

cross-env@^7.0.3:
version "7.0.3"
resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-7.0.3.tgz#865264b29677dc015ba8418918965dd232fc54cf"
integrity sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==
dependencies:
cross-spawn "^7.0.1"

cross-spawn-windows-exe@^1.1.0, cross-spawn-windows-exe@^1.2.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/cross-spawn-windows-exe/-/cross-spawn-windows-exe-1.2.0.tgz#46253b0f497676e766faf4a7061004618b5ac5ec"
Expand Down

0 comments on commit 400cd6c

Please # to comment.