Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Deploy service users #1776

Draft
wants to merge 2 commits into
base: fix/allow-download-of-service-users-with-the-same-name
Choose a base branch
from

Conversation

arthurpitman
Copy link
Contributor

What this PR does / Why we need it:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Copy link

github-actions bot commented Mar 11, 2025

Unit Test Results

1 936 tests  +5   1 935 ✅ +5   53s ⏱️ ±0s
  134 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit dd29481. ± Comparison against base commit 7beadb7.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/account/loader ‑ TestLoad/Duplicate_service_user_produces_error
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/account/loader ‑ TestLoad/Load_service_users_with_same_name_but_different_originObjectIds
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/account/loader ‑ TestLoad/Service_users_with_the_different_name_and_same_origin_object_IDs_produce_error
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/account/loader ‑ TestLoad/Service_users_with_the_same_name_and_no_origin_object_IDs_produce_error
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/account/loader ‑ TestLoad/Service_users_with_the_same_name_and_one_missing_origin_object_ID_produce_error
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/account/loader ‑ TestLoad/Service_users_with_the_same_name_and_same_origin_object_IDs_produce_error
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/account/writer ‑ TestWriteAccountResources/two_service_users_with_same_name_but_different_origin_object_IDs

♻️ This comment has been updated with latest results.

@arthurpitman arthurpitman force-pushed the feat/deploy-service-users branch 2 times, most recently from fa6d54f to b4fe856 Compare March 11, 2025 11:34
@arthurpitman arthurpitman added run-e2e-test Manually trigger the E2E tests for reviewed PRs run-iam-test Manually trigger Account Management E2E tests for PRs labels Mar 11, 2025
Copy link

github-actions bot commented Mar 11, 2025

E2E Test Results

1 files   -     2  1 suites   - 266   4m 36s ⏱️ - 17m 4s
2 tests  - 2 035  2 ✅  - 2 032  0 💤  - 2  0 ❌  - 1 
2 runs   - 2 214  2 ✅  - 2 211  0 💤  - 2  0 ❌  - 1 

Results for commit 2b54248. ± Comparison against base commit ad72aae.

This pull request removes 2037 and adds 2 tests. Note that renamed tests count towards both.
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_group
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_policy
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/account ‑ TestLoadResources_Duplicates/Load_Resources_-_duplicate_user
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/deploy ‑ Test_DoDeploy
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/deploy ‑ Test_DoDeploy/Wrong_environment_group
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/deploy ‑ Test_DoDeploy/Wrong_environment_name
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/deploy ‑ Test_DoDeploy/Wrong_project_name
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/deploy ‑ Test_DoDeploy/correct_parameters
…
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/account ‑ TestDeployAndDelete_AllResources
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/account ‑ TestIdempotenceOfDeployment

♻️ This comment has been updated with latest results.

@arthurpitman arthurpitman added run-iam-test Manually trigger Account Management E2E tests for PRs and removed run-iam-test Manually trigger Account Management E2E tests for PRs labels Mar 11, 2025
@arthurpitman arthurpitman force-pushed the feat/deploy-service-users branch from b4fe856 to 2b54248 Compare March 11, 2025 15:08
@arthurpitman arthurpitman added run-iam-test Manually trigger Account Management E2E tests for PRs and removed run-e2e-test Manually trigger the E2E tests for reviewed PRs run-iam-test Manually trigger Account Management E2E tests for PRs labels Mar 11, 2025
@arthurpitman arthurpitman force-pushed the feat/deploy-service-users branch 2 times, most recently from 3721025 to 05ad093 Compare March 17, 2025 13:24
@arthurpitman arthurpitman force-pushed the feat/deploy-service-users branch from 05ad093 to dd29481 Compare March 18, 2025 16:43
Copy link

@arthurpitman arthurpitman changed the base branch from main to fix/allow-download-of-service-users-with-the-same-name March 18, 2025 16:44
@arthurpitman arthurpitman force-pushed the fix/allow-download-of-service-users-with-the-same-name branch 2 times, most recently from 87118a6 to cd1eb47 Compare March 19, 2025 13:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
run-iam-test Manually trigger Account Management E2E tests for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant