fix: validator checking unique names doesn't return early anymore on …

[d0weinberger]

What this PR does / Why we need it:

This fixes a bug where we erroneously return early from unique name validation for classic apis if the scope of the config-to-check differs from a scope of the configs we have already seen before.

YAML to validate

configs:
  - id: settings-1
    config:
      name: Duplicated
      template: dashboard-share-settings.json
      skip: false
    type:
      api:
        name: dashboard-share-settings
        scope:
          type: value
          value: scope-0
  - id: settings-2
    config:
      name: Duplicated
      template: dashboard-share-settings.json
      skip: false
    type:
      api:
        name: dashboard-share-settings
        scope:
          type: value
          value: scope-1
  - id: settings-3
    config:
      name: Duplicated
      template: dashboard-share-settings.json
      skip: false
    type:
      api:
        name: dashboard-share-settings
        scope:
          type: value
          value: scope-1

Current (wrong) log output:

2025-03-25T11:17:51+01:00	info	Deploying configurations to environment "platform_env"...
2025-03-25T11:17:51+01:00	info	Deploying 3 independent configuration sets in parallel...
2025-03-25T11:17:51+01:00	info	[coord=test:dashboard-share-settings:settings-3][gid=2]	Deploying config
2025-03-25T11:17:51+01:00	info	[coord=test:dashboard-share-settings:settings-1][gid=0]	Deploying config
2025-03-25T11:17:51+01:00	info	[coord=test:dashboard-share-settings:settings-2][gid=1]	Deploying config

Expected log output, introduced with this PR:

2025-03-25T11:30:40+01:00	error	Error: Deployment failed - check logs for details: Errors encountered for 1 environment(s):
	"platform_env": duplicated config name found: configurations test:dashboard-share-settings:settings-3 and test:dashboard-share-settings:settings-2 define the same 'name' "Duplicated"

Special notes for your reviewer:

A test has been added to check the behavior. If you execute the test without the fix, it will fail.

Does this PR introduce a user-facing change?

Yes, validation will fail now for non-unique names in the same scope, whereas before there were cases where validation would succeed, although it shouldn't.

[github-actions]

Unit Test Results

1 943 tests  +1   1 942 ✅ +1   53s ⏱️ ±0s
  134 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 8789145. ± Comparison against base commit 5221b02.

♻️ This comment has been updated with latest results.

[github-actions]

E2E Test Results

    3 files   -   1    269 suites   - 134   26m 59s ⏱️ - 53m 43s
2 048 tests  -   1  2 032 ✅  -   2  2 💤 ±0  14 ❌ +1 
2 227 runs   - 181  2 211 ✅  - 182  2 💤 ±0  14 ❌ +1 

For more details on these failures, see this check.

Results for commit 894fbe0. ± Comparison against base commit f31a9f7.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.

github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationClassic
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationPlatform

github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/deploy/internal/classic ‑ TestValidate_ErrorForSameNameAndScopeWithDifferentScopeCheckedEarlier

♻️ This comment has been updated with latest results.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Laubi]

10/10 comment

[d0weinberger]

Thx!