Return muted as a boolean instead of a function
#156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this returns the `howl.mute` which returns the entire Howler object, but the type says this should be a boolean. Looking at [howler.js](https://github.com/goldfire/howler.js/blob/a2a47933f1ffcee659e4939a65e075fa7f25706c/src/howler.core.js#L1153), it looks like the mute boolean is never publicly exposed. From testing, just checking the volume at 0 doesn't work. It's not great to expose private properties like this, but I expect Howler to be stable enough and this is better than existing functionality.
|
I see this was already being discussed in #141. I'm fine with the suggestion to remove it as well but it's at least useful in some cases. LMK what you think here. |
|
Actually from further testing, this doesn't work -- it returns |
|
@nwestbury should hopefully have a release in the next week or two for v4 which address this issues amongst others. Notably it involves a rewrite against a newer version of React in order to make use of |
|
@E-Kuerschner Awesome. Appreciate your work! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this returns the
howl.mutewhich returns the entire Howler object, but the type says this should be a boolean.Looking at howler.js, it looks like the mute boolean is never publicly exposed from Howler, unfortunately. From testing, just checking the volume at 0 doesn't work.
It's not great to expose private properties like this, but I expect Howler to be stable enough and this is better than existing functionality.