Port merry-go-round testcase from compass #284
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewdnolan
added
in progress
cbegeman
reviewed
Mar 20, 2025
|
|
||
|
|
||
| def add_merry_go_round_tasks(component): | ||
| resolution = 5 |
There was a problem hiding this comment.
Suggested change
| resolution = 5 | |
| resolution = 5. # Resolution provided in [units] |
Replace [units] with m or km
cbegeman
reviewed
Mar 20, 2025
| if not (vert_coord == 'z-level' or vert_coord == 'sigma'): | ||
| raise ValueError('Vertical coordinate {vert_coord} not supported') | ||
|
|
||
| lx, ly = (500, 5) |
There was a problem hiding this comment.
These should be moved to the config file
cbegeman
reviewed
Mar 20, 2025
|
|
||
| lx, ly = (500, 5) | ||
| nx, ny = compute_planar_hex_nx_ny(lx, ly, self.resolution) | ||
| nz = int(50 / (self.resolution / 5)) |
There was a problem hiding this comment.
Should be expressed in terms of a config parameter lz
cbegeman
reviewed
Mar 20, 2025
| # Initialize normalVelocity | ||
| z_mid_edge = z_mid.isel(nCells=ds.cellsOnEdge - 1).mean("TWO") | ||
|
|
||
| x_one_quarters = 0.75 * x_min + 0.25 * x_max |
There was a problem hiding this comment.
Suggested change
| x_one_quarters = 0.75 * x_min + 0.25 * x_max | |
| x_one_quarters = x_min + 0.25 * (x_max - x_min) |
This is more intuitive to me
|
@andrewdnolan Looking great so far! Just a few minor suggestions |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the
Defaulttestcase from themerry_go_roundtestgroup fromcompass,Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes