Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added UnknownUnitError #153

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Added UnknownUnitError #153

merged 1 commit into from
Nov 14, 2023

Conversation

jesper-friis
Copy link
Contributor

Description:

Added UnknownUnitError.

Motivation: Using a unit that is not in the Pint unit registry results in a completely ununderstandable error message. The idea is to issue understandable UnknownUnitError's whenever an unknown unit is used.

Currently this error is only imported by DLite, but the intention is to used in tripper as well.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.
  • Testing.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdbbd06) 75.08% compared to head (7477184) 75.10%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   75.08%   75.10%   +0.01%     
==========================================
  Files          17       17              
  Lines        1405     1406       +1     
==========================================
+ Hits         1055     1056       +1     
  Misses        350      350              
Files Coverage Δ
tripper/mappings/mappings.py 66.39% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesper-friis jesper-friis merged commit abd7159 into master Nov 14, 2023
@jesper-friis jesper-friis deleted the unknown-unit-error branch November 14, 2023 08:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants