Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added comment suggested by Francesca #201

Merged
merged 6 commits into from
May 15, 2024
Merged

Added comment suggested by Francesca #201

merged 6 commits into from
May 15, 2024

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Apr 3, 2024

Description

Added comment suggested by Francesca that fell out from a previous PR.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

@jesper-friis jesper-friis requested a review from francescalb April 3, 2024 15:32
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (3c87165) to head (aafb764).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   78.42%   78.42%           
=======================================
  Files          18       18           
  Lines        1650     1650           
=======================================
  Hits         1294     1294           
  Misses        356      356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to clarify the comment and corrected language.

@francescalb francescalb self-requested a review May 15, 2024 07:29
@francescalb francescalb merged commit bc8b393 into master May 15, 2024
17 checks passed
@francescalb francescalb deleted the comment branch May 15, 2024 12:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants