Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changed EMMO representation of function arguments from datasets to datum #203

Merged
merged 3 commits into from
May 9, 2024

Conversation

jesper-friis
Copy link
Contributor

Description

Changed EMMO representation of function arguments from datasets to datum.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (36dd746) to head (2707285).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   78.42%   78.42%           
=======================================
  Files          18       18           
  Lines        1650     1650           
=======================================
  Hits         1294     1294           
  Misses        356      356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but be aware that this migt be a breaking change for some. Should there be a release in advance?

@jesper-friis jesper-friis merged commit 73ef6ea into master May 9, 2024
17 checks passed
@jesper-friis jesper-friis deleted the fix_functiondoc branch May 9, 2024 04:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants