Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dataset TODOs #279

Merged
merged 37 commits into from
Jan 3, 2025
Merged

Dataset TODOs #279

merged 37 commits into from
Jan 3, 2025

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Dec 30, 2024

Description

Fix the __TODO__'s in dataset.py. This includes:

  • adding context argument to get_prefixes() and get_shortnames().
  • update as_jsonld() to correctly handle multiple contexts provided with the _context keyword argument.

Note: This PR builds on top of PR #275.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

jesper-friis and others added 30 commits December 15, 2024 19:18
  - Allow to add other types of entries to the triplestore that are not
    datasets. Ex: samples, models, instruments, people, projects...
  - Renamed list_data_iris() to search_iris(). It can now be use to search
    for all types of entries.
  - Renamed prepare() to as_jsonld() and made it part of the public API
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.69%. Comparing base (415fa4f) to head (b61b00c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tripper/dataset/dataset.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   78.66%   78.69%   +0.02%     
==========================================
  Files          21       21              
  Lines        2222     2229       +7     
==========================================
+ Hits         1748     1754       +6     
- Misses        474      475       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesper-friis jesper-friis changed the base branch from master to tabledoc-csv December 30, 2024 17:53
Base automatically changed from tabledoc-csv to master January 3, 2025 22:34
@jesper-friis jesper-friis merged commit 6101c87 into master Jan 3, 2025
19 checks passed
@jesper-friis jesper-friis deleted the dataset-todos branch January 3, 2025 22:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant