-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Dataset TODOs #279
Merged
Merged
Dataset TODOs #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow to add other types of entries to the triplestore that are not datasets. Ex: samples, models, instruments, people, projects... - Renamed list_data_iris() to search_iris(). It can now be use to search for all types of entries. - Renamed prepare() to as_jsonld() and made it part of the public API
For more information, see https://pre-commit.ci
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Co-authored-by: Tor S. Haugland <torshaugland@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 78.66% 78.69% +0.02%
==========================================
Files 21 21
Lines 2222 2229 +7
==========================================
+ Hits 1748 1754 +6
- Misses 474 475 +1 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 2, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the
__TODO__
's in dataset.py. This includes:context
argument to get_prefixes() and get_shortnames().as_jsonld()
to correctly handle multiple contexts provided with the_context
keyword argument.Note: This PR builds on top of PR #275.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.