Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change pathlib to be pathlib and not as uri. This fixes opening in wi… #303

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

francescalb
Copy link
Contributor

…ndows

Description

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.72%. Comparing base (fd937aa) to head (6ad323e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   76.72%   76.72%           
=======================================
  Files          22       22           
  Lines        2415     2415           
=======================================
  Hits         1853     1853           
  Misses        562      562           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescalb francescalb merged commit 4f27c66 into master Jan 9, 2025
21 checks passed
@francescalb francescalb deleted the flb/openfile_in_windows branch January 9, 2025 13:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants