-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added create_database() and remove_database() methods. #39
Conversation
Codecov ReportBase: 73.57% // Head: 73.10% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 73.57% 73.10% -0.48%
==========================================
Files 10 10
Lines 598 621 +23
==========================================
+ Hits 440 454 +14
- Misses 158 167 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to come up with a better way of updating/changing the initialization interface for the backends. Adding an unused parameter to all of them whenever one changes seems extremely inefficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, the changes are fine. Since I still have to start the integration with OntoREC, do you need more proper code testing for the final merge of these features?
I also share Casper's point, maybe this approach won't scale in the future.
OK, I removed the explicit explicit database argument from Triplestore.init() |
I don't think this was the point. The point was to design a replacement interface and procedure of handling this. This issue is not one that is to be solved in this PR, but rather a new issue should be opened and this interface and procedure should be updated in another PR. |
This PR provides a common API for backends with multiple databases. It does not require anything change in code in backends that doesn't support multiple databases. |
Closes #34
Closes #38
Add support for backends that supports multiple databases, like stardog and graphdb