Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Separated base_iri argument from triplestore_url in rdflib backend #49

Merged
merged 4 commits into from
Dec 16, 2022

Conversation

jesper-friis
Copy link
Contributor

Before gave rdflib the base_iri argument an additional meaning not documented in Triplestore.init(). This is now taken over by the triplestore_url argument.

Before gave rdflib the `base_iri` argument an additional meaning not
documented in Triplestore.__init__(). This is now sorted out.
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2022

Codecov Report

Base: 73.32% // Head: 73.10% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (9beba40) compared to base (f1039cb).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   73.32%   73.10%   -0.23%     
==========================================
  Files          12       12              
  Lines         746      751       +5     
==========================================
+ Hits          547      549       +2     
- Misses        199      202       +3     
Impacted Files Coverage Δ
tripper/backends/rdflib.py 89.39% <83.33%> (-4.16%) ⬇️
tripper/utils.py 84.15% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

CasperWA
CasperWA previously approved these changes Dec 16, 2022
daniel-sintef
daniel-sintef previously approved these changes Dec 16, 2022
Copy link
Contributor

@daniel-sintef daniel-sintef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think backends should silently allow parameters they don't use. As this could confuse users (imagine one trying to figure out why the base_iri doesn't work, because they need to use triplestore_url).

I would suggest including a warning if the base_iri is provided, that it is unused.

@jesper-friis jesper-friis dismissed stale reviews from daniel-sintef and CasperWA via 9beba40 December 16, 2022 14:07
@jesper-friis jesper-friis merged commit 46f3a05 into main Dec 16, 2022
@jesper-friis jesper-friis deleted the rdflib-args branch December 16, 2022 14:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants