Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Simplify use of the Triplestore triples() and remove() methods #51

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

jesper-friis
Copy link
Contributor

Closes #50

Changed arguments of the Triplestore triples() and remove() methods to make them easier to use.

Ensured backward compatibility.

to make them easier to use.

Ensured backward compatibility.
@jesper-friis jesper-friis added the Priority: Low Low priority issue/PR label Dec 11, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 74.25% // Head: 74.12% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (4d77b23) compared to base (62b83f0).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   74.25%   74.12%   -0.13%     
==========================================
  Files          12       12              
  Lines         703      715      +12     
==========================================
+ Hits          522      530       +8     
- Misses        181      185       +4     
Impacted Files Coverage Δ
tripper/triplestore.py 77.63% <75.00%> (-0.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jesper-friis jesper-friis removed the Priority: Low Low priority issue/PR label Dec 12, 2022
Copy link
Contributor

@daniel-sintef daniel-sintef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create an issue to create something remove code duplication.

@jesper-friis jesper-friis enabled auto-merge (squash) December 16, 2022 13:15
@jesper-friis jesper-friis merged commit f1039cb into main Dec 16, 2022
@jesper-friis jesper-friis deleted the 50-triples-argument branch December 16, 2022 13:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify use of the Triplestore triples() and remove() methods
3 participants