Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ENCD-3707-scrub-proposed-preliminary #2054

Merged
merged 4 commits into from
Nov 30, 2017

Conversation

keenangraham
Copy link
Contributor

Remove a few more mentions of proposed and preliminary statuses where they are no longer needed. You'll still find them mentioned in changelogs and upgrades but this is expected.

keenangraham and others added 2 commits November 20, 2017 16:56
Removed uses of the “proposed” state from all Javascript code. I found no uses of “preliminary.” ENCD-3707
@caseylitton
Copy link
Contributor

What about 'proposed' in these files?
-status-proposed in ./src/encoded/static/scss/encoded/modules/_characterizations.scss
-QUICKVIEW_STATUSES_BLOCKED in ./src/encoded/visualization.py
-proposed_count in ./src/encoded/schemas/award.json

keenangraham and others added 2 commits November 21, 2017 15:43
proposed_count doesn’t have anything to do with the experiment proposed state. ENCD-3707
@forresttanaka
Copy link
Contributor

I reverted the proposed_count change, but left the scss the way it is, as more things in there exist that aren’t used anymore, and ENCD-3629 will clean all of that out.

@caseylitton caseylitton merged commit 9f8e14d into master Nov 30, 2017
@caseylitton caseylitton deleted the ENCD-3707-scrub-proposed-preliminary branch November 30, 2017 19:19
gabdank pushed a commit that referenced this pull request Dec 14, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants