Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ENCD-3546 Create 'save and add' button to add forms #2100

Merged
merged 2 commits into from
Jan 8, 2018

Conversation

davisagli
Copy link
Contributor

No description provided.

Copy link
Contributor

@forresttanaka forresttanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how this works, and I see no obvious problems, and this is a nice capability.

form.js has a couple small AirBnB compliance errors that existed before this ticket. Not sure if we want to fix them for this ticket, or as part of another. One is very minor, the other involves changing an <a> to a <button>.

@davisagli
Copy link
Contributor Author

@forresttanaka I fixed the first one; for the second, do we have a style to make a button appear like a link?

@forresttanaka
Copy link
Contributor

forresttanaka commented Dec 22, 2017

It would have to be styled to fit that dropdown, I’m pretty sure.

I think a viable alternative is to keep it an <a> but just remove the href. AirBnB is fine with that. It technically becomes an HTML5 placeholder link, but with a click handler, it seems like it should work.

@caseylitton caseylitton changed the title ENCD-3546 Add 'Save & Add Another' button to add forms ENCD-3546 Create 'save and add' button to add forms Jan 8, 2018
@caseylitton caseylitton merged commit 136bdc8 into master Jan 8, 2018
@caseylitton caseylitton deleted the ENCD-3546-save-and-add branch January 8, 2018 19:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants