-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Handle out-of-order ERA5 time coord issue #189
Handle out-of-order ERA5 time coord issue #189
Conversation
It appears that ECMWF's CDS has started returning data where the time-coordinate isn't monotonic anymore and the timesteps are randomly ordered. This commit adds sorting by time during load-time. This may slow down calculations and a fix where input files are overwritten could be made in future Related to EUREC4A-UK#183
@sjboeing I've manually verified that this works. We can't test it with our test-data because we don't download data from ECMWF during testing. Could you give it a try too and let me know what you think? Thanks :) |
Hi Leif, This looks good and it seems to work for me. While working on this, I did run into an issue with domain versioning: |
Hmm.. I think this means you downloaded this domain data before we added the versioning (#87). But this is fine :) Another way to solve it is just create a filename called |
…ix-era5-time-monotinicity-issue
I'll merge this in once the tests pass @sjboeing with this change the changelog is getting quite long: https://github.com/leifdenby/lagtraj/blob/fix-era5-time-monotinicity-issue/CHANGELOG.md - how do you feel about me creating release |
Ah, thanks Leif. merging this and creating a new release sounds good. The other issue occurred with data downloaded just this week. I will check and see if it is something I missed and create an issue if it persists. |
It appears that ECMWF's CDS has started returning data where the time-coordinate isn't monotonic anymore and the timesteps are randomly ordered. This commit adds sorting by time during load-time. This may slow down calculations and a fix where input files are overwritten could be made in future
Related to #183