nginx.conf: Remove duplicated daemon off; from nginx.conf
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per nginx-proxy/nginx-proxy@de4cb3d this was set previously in the nginx.conf which we override manually in our dockerimage to copy our own custom config and since it was override there was no duplication. But now since this has been moved to the procfile it is getting set by default and and since we also have this in our config it is getting duplicated. In order to use the image directly we can remove this from our configs Or if needed we can change the procfile as per our need
|
CC @mrrobot47 |
mrrobot47
approved these changes
May 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per nginx-proxy/nginx-proxy@de4cb3d this was set previously in the nginx.conf which we override manually in our dockerimage to copy our own custom config and since it was override there was no duplication. But now since this has been moved to the procfile it is getting set by default and and since we also have this in our config it is getting duplicated.
In order to use the image directly we can remove this from our configs
Or if needed we can change the procfile as per our need