Add support to independently version docker images #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
This was referenced Aug 10, 2018
rahulsprajapati
suggested changes
Aug 21, 2018
img-versions.json
Outdated
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "easyengine/mailhog": "v4.0.0-beta.5", | |||
There was a problem hiding this comment.
I think we should be using this docker image version from this file to all the places now. https://github.com/EasyEngine/easyengine/blob/develop-v4/php/EE/Migration/Containers.php#L39
https://github.com/EasyEngine/site-wp-command/blob/develop/src/Site_WP_Docker.php#L128
There was a problem hiding this comment.
Will updated in https://github.com/EasyEngine/easyengine/blob/develop-v4/php/EE/Migration/Containers.php#L39
For site-command and site-wp-command:
EasyEngine/site-command#95
EasyEngine/site-type-wp#15
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
rahulsprajapati
approved these changes
Aug 21, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1156