Move nginx config to mustache #14
Conversation
| deny all; | ||
| } | ||
| } | ||
| # Yoast sitemap |
There was a problem hiding this comment.
This whole Yoast section needs to be removed.
| fastcgi_pass php:9000; | ||
|
|
||
| } | ||
| # EasyEngine (ee) utilities |
There was a problem hiding this comment.
Remove section # EasyEngine (ee) utilities. Leave the last location ~* .(css|js)$ block.
| @@ -0,0 +1,57 @@ | |||
| # Redis NGINX CONFIGURATION | |||
| # DO NOT MODIFY, ALL CHANGES LOST AFTER UPDATE EasyEngine (ee) | |||
| set $skip_cache 0; | |||
There was a problem hiding this comment.
Rename variable $skip_cache to $skip
mbtamuli
changed the title
| add_header "Access-Control-Allow-Origin" "*"; | ||
| access_log off; | ||
| log_not_found off; | ||
| expires max; |
There was a problem hiding this comment.
@mbtamuli this location block is not recommended on dev sites. Static file caching should be only used in production.
There was a problem hiding this comment.
We'll configure this based in the next release which will have [--dev|--prod] flags or something similar, to specify if it is a site in development or production.
| set_unescape_uri $key $arg_key ; | ||
| redis2_query set $key $echo_request_body; | ||
| redis2_query expire $key 14400; | ||
| redis2_pass ee4_redis:6379; |
There was a problem hiding this comment.
Can we stop using the word ee4? There will be only one ee after this.
| post_max_size = 100M | ||
|
|
||
| [mail function] | ||
| sendmail_path = /usr/sbin/sendmail -S mail:1025 |
There was a problem hiding this comment.
@mbtamuli does this work in docker?
There was a problem hiding this comment.
This line is for Docker only. These PRs are not related to non-docker setup.
There was a problem hiding this comment.
So did we test within docker if there is a sendmail program at /usr/bin/sendmail?
There was a problem hiding this comment.
sendmail_path = /usr/sbin/sendmail -S mail:1025
https://github.com/EasyEngine/dockerfiles/blob/master/php/Dockerfile#L15
I think this package ssmtp is installing /usr/sbin/sendmail because the above line is working. It is sending mail which is recieved by MailHog.
Postfix mail is being tracked on in a different issue - EasyEngine/easyengine#1028
|
@mbtamuli there will be only one template for WordPress server block. |
kirtangajjar
changed the title
|
Related to this PR - EasyEngine/easyengine#1040 |
| location = /robots.txt { | ||
| # Some WordPress plugin gererate robots.txt file | ||
| # Refer #340 issue | ||
| return 200 'User-agent: *\nDisallow: /'; |
There was a problem hiding this comment.
@kirtangajjar This line will deindex site from the search engines! 😨
Nginx won't use robotos.txt files on disk.
Please remove this line.
There was a problem hiding this comment.
@mbtamuli this need to be changed
| include fastcgi_params; | ||
| fastcgi_pass php:9000; | ||
| } | ||
| location ~* \.(css|js)$ { |
There was a problem hiding this comment.
@kirtangajjar remove this location block at all. A 5s cache is no useful.
Is there way we add --env check? In dev env this block should not exist. In production, this can exist with longer expiry.
There was a problem hiding this comment.
Dev env will be handled in beta2. Please assume all config is for prod. We'll add flag as well as separate config for dev in next release. @rahul286
There was a problem hiding this comment.
Ok for production, make 5s atleadt 1d.
| post_max_size = 100M | ||
|
|
||
| [mail function] | ||
| sendmail_path = /usr/sbin/sendmail -S mail:1025 |
There was a problem hiding this comment.
So did we test within docker if there is a sendmail program at /usr/bin/sendmail?
No description provided.