Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add custom ssl support for php site #63

Merged
merged 5 commits into from
Jan 25, 2019
Merged

Add custom ssl support for php site #63

merged 5 commits into from
Jan 25, 2019

Conversation

sagarnasit
Copy link
Contributor

@sagarnasit sagarnasit requested a review from mrrobot47 January 16, 2019 10:55
@sagarnasit sagarnasit self-assigned this Jan 16, 2019
sagarnasit and others added 4 commits January 16, 2019 17:11
@sagarnasit
Move custom ssl call before www_ssl_wrapper
78cc80b
@sagarnasit
Catch exception and call site cleanup
368335e
@mrrobot47
Fix spelling mistake and add example
22cfd01 
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
@mrrobot47
Update test check args
add5a24 
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
mrrobot47
mrrobot47 approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@mrrobot47 mrrobot47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrrobot47 mrrobot47 merged commit add5a24 into EasyEngine:develop Jan 25, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mrrobot47 mrrobot47 mrrobot47 approved these changes

Assignees

@sagarnasit sagarnasit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagarnasit @mrrobot47